[CoE Starter Kit - Feature]: Switch to using createdBy.id instead of createdBy.displayName to identify SYSTEM created environments

[manuelap-msft]

Is your feature request related to a problem? Please describe.

The Get Environments action returns the following for system and FinOps environments:

                "createdBy": {
                    "id": "SYSTEM",
                    "displayName": "SYSTEM",
                    "type": "NotSpecified"
                },

"createdBy": {
"id": "Microsoft Dynamics Deployment Service",
"displayName": "SYSTEM",

Currently we use the displayName to identify SYSTEM created environments but we've recently learned that this gets localized and there may also be plans to remove the displayName from this response altogether due to privacy reasons.

Describe the solution you'd like

We need to switch to using createdBy.id to identify system created environments.

For FinOps currently we use displayName which is SYSTEM for both cases (so both for SYSTEM environments as well as FinOps environments the displayName is the same) but when we switch to ID we'd have to handle both id=SYSTEM and id=Microsoft Dynamics Deployment Service

Describe alternatives you've considered

No response

Additional context?

No response

[manuelap-msft]

Alternatively, we could use createdBy.type = NotSpecified

"createdBy": {
"id": "Microsoft Dynamics Deployment Service",
"displayName": "SYSTEM",
"type": "NotSpecified"
}

"createdBy": {
"id": "SYSTEM",
"displayName": "SYSTEM",
"type": "NotSpecified"
}

type is set to NotSpecified for all system/partner created environments and would be a "catch all" if there are other ids like Microsoft Dynamics Deployment Service out there, so we could check for if createdBy.type = NotSpecified then set maker to SYSTEM

[CoEStarterKitBot]

@manuelap-msft This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.