Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Compliance detail get requested for apps under thresholds #6208

Closed
1 task done
lukas-nC opened this issue Aug 1, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@lukas-nC
Copy link

lukas-nC commented Aug 1, 2023

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

Hello,

as I've started the compliance process, I recognized that for almost all the apps in the default environment, the compliance details has been requested.
The investigation of the Flow run showed that even when the app doesn't meet one of the configured thresholds, this condition
image
was nearly always true.
The critical part seems to be this
image
At the beginning of the flow, everything is fine.
Then there comes an app which is over the configured launches.
Because BYODL isn't configured in this case, the variable AppSessionsLast30Days, the set action results in an error
image
Because of this the variable AppSessionsLast30Days doesn't get changed and still has a value above the threshold from the previous app, which results in this
image

So the variable AppSessionsLast30Days doesn't get the correct value for the current app and therefore starts the compliance process

Expected Behavior

The compliance process should only be triggered for apps which are over the thresholds.

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.9

What app or flow are you having the issue with?

Admin | Compliance detail request v3

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

Activate the compliance process with the Setup Wizard

Anything else?

Fix could be to set the AppSessionsLast30Days variable at the end of the Apply to each to 0
or
image
the Set App Launches form ... action needs an expression like that.

PS, If you modify the flow, u may rename this action :-)
image

@lukas-nC lukas-nC added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Aug 1, 2023
@lukas-nC lukas-nC changed the title [CoE Starter Kit - BUG] Compliance detail get requested for apps thresholds [CoE Starter Kit - BUG] Compliance detail get requested for apps under thresholds Aug 1, 2023
@Jenefer-Monroe
Copy link
Collaborator

Thanks so much for the debugging and the coalesce solution recommendation. I've updated with that (and changed the var set action name :)) for Sept.

image

@CoEStarterKitBot
Copy link
Collaborator

@lukas-nC This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Archived in project
Development

No branches or pull requests

3 participants