Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Admin | add Maker to a group - success even if the owner doesn't have the sufficient privilege to add the member #6564

Closed
1 task done
tocri opened this issue Sep 8, 2023 · 3 comments
Assignees
Labels
coe-starter-kit CoE Starter Kit issues enhancement New feature or request

Comments

@tocri
Copy link

tocri commented Sep 8, 2023

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

hi,

I forgot to add my admin coe user as owner of the AAD security group that i use for makers.
The flow status is successful even if the Add member to a group action fails.

I don't really know if it's a bug or if it's intentional.

For my part, I was surprised after a few days to see that there were no members in this group.

image image

Expected Behavior

maybe make the flow fail so that we can see it in the COE admin command center?

What solution are you experiencing the issue with?

Core

What solution version are you using?

September

What app or flow are you having the issue with?

Admin [ Add Maker to a group

What method are you using to get inventory and telemetry?

None

Steps To Reproduce

No response

Anything else?

No response

AB#1414

@tocri tocri added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Sep 8, 2023
@Jenefer-Monroe
Copy link
Collaborator

It was intentional in that we were catching the case where the user is already a member.
But I can make this better to fail for other things like this.
Thank you for posting!

@Jenefer-Monroe Jenefer-Monroe added enhancement New feature or request and removed bug Something isn't working labels Sep 8, 2023
@Jenefer-Monroe
Copy link
Collaborator

Fix is to only try to add if not already a member. This way if it fails it wont be for a reason we want to catch.

Image

@CoEStarterKitBot
Copy link
Collaborator

@tocri This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coe-starter-kit CoE Starter Kit issues enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants