Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] SYNC HELPER - Cloud Flows -> HELPER - Maker Check - failing due to no maker id coming back from flow #6599

Closed
1 task done
Rajeshgn053 opened this issue Sep 14, 2023 · 8 comments
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@Rajeshgn053
Copy link

Rajeshgn053 commented Sep 14, 2023

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

SYNC HELPER - Cloud Flows is triggered to Insert/Update an Flow. After updating the FlowOwnerID to Derived owner, it will pass through "Maker check - Derived Owner" action to identify, whether its an orphan/System/Valid user.

In our case the MakerId is set Blank, since both FLow Owner & Maker details are not able to fetch. Though this MakerId is passed as Blank along with MakerDisplayName as Blank. The output is coming as "System" user. Which is leading to update the Maker column details with blanks FlowOwnerID . And hence, its failing due to the blank reference entries under Make columns. Please check the series of screenshots that justifies the problem.
Maker Check1-

Maker Check2-

Maker Check3-

Expected Behavior

The child flow "HELPER - Maker Check", should return the user response as Orphan user, for MakerId blank value. In this case, the logic will pick the proper "Upsert" action to avoid updating Maker fields.
Maker Check4-

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.8

What app or flow are you having the issue with?

SYNC HELPER - Cloud Flows

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

No response

Anything else?

No response

AB#1385

@Rajeshgn053 Rajeshgn053 added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Sep 14, 2023
@Rajeshgn053
Copy link
Author

FYI - From last 24hrs.. We see ~1300 errors occurred, with same issue. I dont see any changes done on the related flows.

@Rajeshgn053
Copy link
Author

One more observation - We are getting this error for flows that are in "Stopped" state. The MakerId is expecting property called "creator/objectid" from "Get Flow as Admin" action, which is missing on all these instances/errors..

@Jenefer-Monroe
Copy link
Collaborator

Thanks for the good detective work, looks like a product change in what is returned for those cases. I think the fix will have to be like this. Can you please test if for me? Its a rather big change for local fixing so I understand if its too difficult. I dont have any repros of this in my tenant though.

In SYNC HELPER - Cloud Flows

  1. Add a new variable isOrphan, default to false
    image

  2. Add a new condition : length(variables('FlowOwnerID')) is equal to 0
    Move the current call to the helper under "if no", and update the variable with its findings
    Under "if yes" set the isOrphan varable to true
    image

  3. Change the Check if Orphan condition to use the variable instead.
    image

@Jenefer-Monroe
Copy link
Collaborator

Thanks again for posting and please do let me know if you are able to test and if this resolves. If so I will make the same change to apps after a little more testing on my side and ship with next release.

@Jenefer-Monroe Jenefer-Monroe changed the title [CoE Starter Kit - BUG] SYNC HELPER - Cloud Flows -> HELPER - Maker Check [CoE Starter Kit - BUG] SYNC HELPER - Cloud Flows -> HELPER - Maker Check - failing due to no maker id coming back from flow Sep 14, 2023
@Rajeshgn053
Copy link
Author

Sure Jenefer. I need to reproduce the issue in Dev & apply the fix that you recommended.. Keep you posted, once its done...

@Rajeshgn053
Copy link
Author

Hi Jenefer, The fix is working...
Please apply the same on next release & let us know the details..

@Jenefer-Monroe
Copy link
Collaborator

Great thank you for testing! I have upated for apps and flows for Oct release.

@CoEStarterKitBot
Copy link
Collaborator

@Rajeshgn053 This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Status: Done
Development

No branches or pull requests

4 participants