Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Admin | Sync Template v3 (Driver) -> Admin | Sync Template v4 (Flows) / v4 (Apps) /v3 (Connection Identities) #6607

Closed
1 task done
Rajeshgn053 opened this issue Sep 14, 2023 · 5 comments
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@Rajeshgn053
Copy link

Rajeshgn053 commented Sep 14, 2023

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

Note - This issue is related to #6451 & #6545. We want the fix recommended from our research to be implemented on COE next releases. Hence, raising it as new & requesting to get this fix applied on next releases.

  1. “Admin | Sync Template v3 (Driver)” flow will trigger every day. Gets all the environments & loops them to Sync “Environments” table (Let’s say started at 9AM EST).

  2. Prod tenant has ~3650 environments, which is taking total time of ~13 hrs (Ends at 10PM EST) to complete rest of the logic.
    Note- ‘DelayInventory’ environment variable is set to “No”

Picture1

  1. An environment that is placed at ~3156 iteration position, gets deleted ~11AM EST

  2. By the time the iteration picks this environment (~7pm EST), logic just checks the dataverse table properties & proceeds updating the respective “Environments” row.

Picture2

  1. This leads in triggering the related sync flows & finally leading to the above errors.

• Admin | Sync Template v4 (Apps)
Action – Get_Apps_as_Admin
Error - "The environment '' could not be found"

• Admin | Sync Template v4 (Flows)
Action – List Flows as Admin (V2)
Error - "You are not permitted to make flows in this [environment GUID]"

• Admin | Sync Template v3 (Connection Identities)
Action – Get_Connections_as_Admin
Error - "The environment '' could not be found"

Please check our solution in Expected behavior section****

It should check the Environment existence, before performing next actions on each iteration.

Expected Behavior

Solution – For each iteration, before checking the dataverse properties, just check the environment exists or not (via Get Environment as Admin action), followed by Parallel branch operation.

If the respective environment is deleted by that time, an error occurs & empty scope branch action will be triggered, ending the respective iteration wit compose step (This step to avoid Flow run failure status, in negative case).
Then next in iteration will trigger.

This set of actions will take care of any Environment that gets deleted, after the loop starts.
Picture3
Picture4
Picture5
Picture6

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.8

What app or flow are you having the issue with?

Admin | Sync Template v3 (Driver)

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

No response

Anything else?

The provided fix is tested, Please apply this fix in nex COE releases

AB#1388

@Rajeshgn053 Rajeshgn053 added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Sep 14, 2023
@Jenefer-Monroe
Copy link
Collaborator

We can consider this change although we havent seen this be a big problem for users. Let me see what the API impact would be and let you know.

@Jenefer-Monroe
Copy link
Collaborator

Added a try catch like this.

Image

@michael-wright-pwc
Copy link

Thank you @Jenefer-Monroe! (I work with @Rajeshgn053). This is much appreciated.

@Jenefer-Monroe
Copy link
Collaborator

You guys earned with your great debugging :)

@CoEStarterKitBot
Copy link
Collaborator

@Rajeshgn053 This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Status: Done
Development

No branches or pull requests

5 participants