Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Admin | Welcome Email v3 has failed for orphaned users #6916

Closed
1 task done
annsarP opened this issue Oct 24, 2023 · 11 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@annsarP
Copy link

annsarP commented Oct 24, 2023

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

Hello, we discovered that Admin | Welcome Email v3 has failed for our service account. This service account appears as typical user in Maker table but has no apps, flows and no User Email, as a consequence flow is failing because "To" field is blank. Only one solution was created with this account. What might be the reason of missing User Email? User Principal Name field is storing e-mail address without any issues.
image
image

Expected Behavior

No response

What solution are you experiencing the issue with?

Core

What solution version are you using?

October 2023

What app or flow are you having the issue with?

Admin | Welcome Email v3

What method are you using to get inventory and telemetry?

None

Steps To Reproduce

No response

Anything else?

No response

AB#286

@annsarP annsarP added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Oct 24, 2023
@Jenefer-Monroe
Copy link
Collaborator

Yes unfortunately that is a requirement of the identity running the kit, it must be email enabled. Please see What identity should I install the CoE Starter Kit with?

@annsarP
Copy link
Author

annsarP commented Oct 26, 2023

Hi, our service account that we are running the kit with has User Email field filled. However, the value of this field is missing for other service accounts and for no-longer existing user accounts, is that because for these accounts email is not enabled (no access to Office 365 mailbox)?

@annsarP
Copy link
Author

annsarP commented Oct 26, 2023

Hi I investigated a little more and one of the users from Makers table has no User Email as well but is active user, has licenses assigned and mailbox enabled. What might be the reason for missing User Email field? Is Maker table updated anyway? So for example if user's manager will change - will we see this change for this user in the Maker table after one of the syncs or Maker row is just being added and after that only resources created by this person are changing?

@Jenefer-Monroe
Copy link
Collaborator

There is a flow called CLEANUP - Admin | Sync Template v3 (Orphaned Makers) which runs each week and updates this type of information. Can you can go trigger it now to run and see if that fixes up these users?

@annsarP
Copy link
Author

annsarP commented Oct 27, 2023

I ran it and unfortunately number of Makers without User Email is still 22. Can lack of apps, flows, solutions etc. be the reason?

@Jenefer-Monroe
Copy link
Collaborator

Jenefer-Monroe commented Oct 27, 2023

Go to the run of the flow, find one of your 22 users with missing email in the output of "List Makers"
Find that iteration of the loop and see what is returned for Get Maker, especially for these properties
"userisorphan"
"userissystem"
"userisserviceprinciple"

image

@annsarP
Copy link
Author

annsarP commented Oct 30, 2023

None of these 22 users is contained in outputs from "List Makers" action 😄

@Jenefer-Monroe
Copy link
Collaborator

I'm a little confused now.
The flow in questions (Admin | Welcome Email v3) runs when a user is added to the Maker table but it appears they are not in the maker table.
Can you please restate what failure you are hitting right now?

@annsarP
Copy link
Author

annsarP commented Oct 31, 2023

Sorry, my bad, we have so many Maker rows (over 1k) that it couldn't search for these users via CTRL+F in outputs. I pasted them into Notepad and I was able to find user there. Here are "Get Maker" properties for user (Service Account) that flow Welcome Email failed for (no UserEmail):
image

For the user (not Service Account) that has no UserEmail properties are following:
image
(So I think in this case userisorphan:true is the reason, correct?)

@Jenefer-Monroe
Copy link
Collaborator

Jenefer-Monroe commented Oct 31, 2023

Yes that does appear to be the case. If the user is orphaned when they get added to the Maker table then the send of the email will fail.
I've added a second catch here to exit early if the maker is orphaned (or service account which was there previously)
image

Thanks for posting!

@Jenefer-Monroe Jenefer-Monroe changed the title [CoE Starter Kit - BUG] Admin | Welcome Email v3 has failed for service account [CoE Starter Kit - BUG] Admin | Welcome Email v3 has failed for orphaned users Oct 31, 2023
@CoEStarterKitBot
Copy link
Collaborator

@annsarP This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Status: Done
Development

No branches or pull requests

4 participants