Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] DLP Impact Analysis App bug(s) #6981

Closed
1 task done
accvik opened this issue Nov 2, 2023 · 4 comments
Closed
1 task done

[CoE Starter Kit - BUG] DLP Impact Analysis App bug(s) #6981

accvik opened this issue Nov 2, 2023 · 4 comments
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@accvik
Copy link

accvik commented Nov 2, 2023

Does this bug already exist in our backlog?

  • I have checked and confirm this is a new bug.

Describe the issue

Seems like a bug when trying to export the impact analysis to csv:

image

This is me trying to edit a "Exclude certain environments" Scope DLP where the default environment currently is excluded. I want it to be "Available" instead by doing:
Open the new DLP Impact Analysis App -> "Edit Policy" -> Select Default environment ->Press "Remove from policy"->Next

No impacted apps/flows visibly, there should be, and when pressing "Export to CSV" the flow run fails.
I believe the logic does not account for the case when a policy that has the scope "Exclude certain environments", and we remove such an exception, it does not get added to the data of envs that should be checked. Can that be correct? Or how can I get around this?
(Since if I try the app with a Scope "Add multiple environments" and try to add an environment, the data shows up and the flow runs fine).

Really appreciate an answer, need to assess this DLP change :) Thanks.

(By the way, either the data is wrong or the showing within the app that every Environment in my list is called the same..? This is only also appearing for when I'm editing the "Exclude certain environments" DLP. In the Admin View App, all environment names are correct.
image

(By the way 2, also when editing the same DLP, the Default Environment incorrectly shows up in the "Available" list in the DLP Impact Analysis app, which is should not:
image

From admin center:
image

Expected Behavior

No response

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.15

What app or flow are you having the issue with?

DLP Editor>Parse impacted resources into CSV

What method are you using to get inventory and telemetry?

Cloud flows

Steps To Reproduce

See above

Anything else?

No response

AB#584

@accvik accvik added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Nov 2, 2023
@Jenefer-Monroe
Copy link
Collaborator

I do repro this. It's pretty complicated logic though so over to area owner for investigation.

@accvik
Copy link
Author

accvik commented Nov 3, 2023

Thanks for the update Jenefer. Will I continue getting updates through here?

@LucasCXavier
Copy link

Hi team,
I'm experiencing the same error when attempting to run the impact analysis on a DLP with the 'Add all environments' scope.

@accvik
Copy link
Author

accvik commented Jan 23, 2024

Is there a planned fix for the February release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Status: Done
Development

No branches or pull requests

6 participants