Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversationTranslator Error - this.cancelSpeech is not a function #366

Closed
harryesslemont opened this issue Apr 27, 2021 · 4 comments · Fixed by #367
Closed

ConversationTranslator Error - this.cancelSpeech is not a function #366

harryesslemont opened this issue Apr 27, 2021 · 4 comments · Fixed by #367
Assignees
Labels
bug Something isn't working

Comments

@harryesslemont
Copy link

harryesslemont commented Apr 27, 2021

I'm having issues with the above error getting thrown when my participants leave a conversation. From my limited understanding of 'this' contexts in js, I believe that this was likely introduced in this commit 529d62c where some arrow functions were replaced.

src/sdk/Transcription/ConversationTranslator.ts Line 372 - onSpeechDisconnected() is the one that is of interest to me, but it looks like the same issue would occur in multiple other areas too.

@glharper glharper added the bug Something isn't working label Apr 28, 2021
@glharper
Copy link
Member

@harryesslemont Confirmed, the onSpeechConnected and onSpeechDisconnected callbacks fire within a Connection context, and the rest (onSpeechRecognized (line 359) through onSpeechSessionStopped) fire within a TranslationRecognizer context. Nice find!

@harryesslemont
Copy link
Author

Any chance of getting this into a release anytime soon? It's currently holding us back from going live with our speech-to-text feature.

@glharper
Copy link
Member

glharper commented May 4, 2021

@harryesslemont It's checked into the 1.17 release, which should go live in about two weeks.

@glharper
Copy link
Member

@harryesslemont v1.17 of SpeechSDK for JavaScript is now live with this fix, available for Node via npm install (npm library homepage) and browser via include (using this link). Thanks again for using Speech SDK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants