Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PNPM 6 support #17

Closed
grvillic opened this issue Dec 9, 2021 · 2 comments
Closed

Add PNPM 6 support #17

grvillic opened this issue Dec 9, 2021 · 2 comments
Assignees
Labels
detector:pnpm The pnpm detector good first issue Good for newcomers status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@grvillic
Copy link
Contributor

grvillic commented Dec 9, 2021

Context

Detector scans PNPM 5 properly and picks up all dependencies as expected, same can't be said for PNPM 6. It seems that PNPM 6 is having silent failures when parsing pnpm-lock.yaml files, hence not only it doesn't pick up any dependency, but it makes it hard to realize the lack of coverage.

Problem

  • Lack of PNPM 6 Support
  • Silent failures

Error log:
LogFailedReadingFile logged SyntaxErrorException: (Line: 20485, Col: 135, Idx: 618058) - (Line: 20485, Col: 139, Idx: 618062): While scanning a plain scalar, find unexpected ':'

Solution

Add support for PNPM 6 detection and parsing

@JamieMagee JamieMagee added type:feature Feature (new functionality) status:ready Ready to start implementation detector:pnpm The pnpm detector and removed enhancement labels Dec 17, 2021
@cobya cobya self-assigned this Mar 25, 2022
@cobya cobya added status:in-progress Someone is working on implementation and removed status:ready Ready to start implementation labels Mar 25, 2022
@cobya
Copy link
Contributor

cobya commented Mar 28, 2022

One of the potential issues I've found while investigating this is the use of github URLs in pnpm-lock.yaml files instead of component versions, ex:

"github.com/xmldom/xmldom/c568938641cc1f121cef5b4df80fcfda1e489b6e"
"github.com/faisalil/react-native-mock/ca38d5e1a922278de30fcf461d2eacd0b16a6363_react-native@0.62.2"
"github.com/joonhocho/react-native-android-action-sheet/f7436395ffb41e23a7770de18601d703913b5a95"

@cobya
Copy link
Contributor

cobya commented May 15, 2024

Closing in favor of #503

@cobya cobya closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:pnpm The pnpm detector good first issue Good for newcomers status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

3 participants