Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn v3+ support and performance #663

Closed
JamieMagee opened this issue Jul 17, 2023 · 7 comments
Closed

Yarn v3+ support and performance #663

JamieMagee opened this issue Jul 17, 2023 · 7 comments
Labels
detector:yarn The Yarn detector type:feature Feature (new functionality)

Comments

@JamieMagee
Copy link
Member

JamieMagee commented Jul 17, 2023

Currently, Component Detection explicitly supports Yarn v1 and v2. We've had some customer reports of poor performance of our yarn detection.

Unfortunately, yarn support has gotten a little more complex recently. Yarn v1 is now considered yarn 'classic'. Yarn 2 and 3 are a complete rewrite of yarn (and are sometimes called 'berry'). The lockfile version has incremented a lot.

Yarn version lockfile version
1+ 1
2.0.0-rc.2 2
2.0.0-rc.5 3
2.0.0-rc.15 4
3.1.0-rc.12 5
3.2.0-rc.12 6
4.0.0-rc.1 7
4.0.0-rc.47 8

We need to evaluate whether or not these lockfile changes are relevant to Component Detection, and the performance of our yarn detection for large projects in general.

AB#2099326

@lvivski
Copy link
Member

lvivski commented Aug 24, 2023

Hi @JamieMagee, I see you had several PRs already merged. Can Component Detection already be used with new Yarn versions?

@MLoughry
Copy link
Contributor

@melotic
Copy link
Member

melotic commented Aug 28, 2023

Hi @JamieMagee, I see you had several PRs already merged. Can Component Detection already be used with new Yarn versions?

This was for infrastructure to support V3. We do not have a specific detector for it yet.

@lvivski
Copy link
Member

lvivski commented Sep 22, 2023

@melotic is there anything we can do to help with the development? Yarn@3 is over 3 times faster at our scale than v1. We would really like to be able to migrate to Yarn@3.

@melotic
Copy link
Member

melotic commented Sep 22, 2023

@melotic is there anything we can do to help with the development? Yarn@3 is over 3 times faster at our scale than v1. We would really like to be able to migrate to Yarn@3.

We're currently planning work to prioritize this in this quarter

@lvivski
Copy link
Member

lvivski commented Nov 8, 2023

Hey @melotic, is there any update on this issue?

@cobya cobya added type:feature Feature (new functionality) detector:yarn The Yarn detector labels Dec 4, 2023
@grvillic
Copy link
Contributor

grvillic commented Dec 7, 2023

@lvivski - Yarn V3 was already merged and enabled by default in the detector. Please give it a go and let us know if you see any issues with it. See release v4.0.8.

@grvillic grvillic closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:yarn The Yarn detector type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

6 participants