Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

add download size info to remotePackage #51

Closed
zwacky opened this issue Jan 5, 2016 · 6 comments
Closed

add download size info to remotePackage #51

zwacky opened this issue Jan 5, 2016 · 6 comments

Comments

@zwacky
Copy link
Contributor

zwacky commented Jan 5, 2016

there are description and packageSize that are undefined. i think it'd be great if you can tell the user before hand what he can expect size-wise.

// current remotePackage dump
appVersion: "0.4.32"
deploymentKey: "8960f81c-xxx"
description: undefined
downloadUrl: "https://codepush.blob.core.windows.net/storagev2/xxx"
failedInstall: false
isMandatory: false
label: "v3"
packageHash: "fbc201670xxx"
packageSize: undefined
@lostintangent
Copy link
Member

The packageSize property should definitely be populated within a remote package response. Let us take a look into this as it may be a bug. Thanks for reporting it!

@dtivel
Copy link
Member

dtivel commented Jan 6, 2016

Thank you for reporting this. I checked in a fix for the CodePush service not reporting package size and updated the live service. The packageSize property should be correct now. Please let me know if you see otherwise.

As for the description property, did you specify an optional description (with the --description parameter) when you released an update? The description should be empty by default.

@zwacky
Copy link
Contributor Author

zwacky commented Jan 6, 2016

cool, I'll try it out tomorrow.

yeah I just omitted the description, that works.

@lostintangent
Copy link
Member

I'm going to close out this bug as resolved, but please re-open it if you experience any issues when testing the new packageSize property tomorrow. Thanks again @zwacky!

@zwacky
Copy link
Contributor Author

zwacky commented Jan 7, 2016

just wanted to confirm: the packageSize is correctly showing now.

also, dunno what i was doing wrong before, but the actual update itself is downloading only parts of it, so the diffing is working perfectly.

@dtivel
Copy link
Member

dtivel commented Jan 7, 2016

Fantastic! Thank you for confirming, @zwacky. Please let us know if you run into any other issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants