Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cordova-number-entry fields indicate valid values are invalid #117

Closed
TimBarham opened this issue Jul 20, 2016 · 2 comments · Fixed by #140
Closed

cordova-number-entry fields indicate valid values are invalid #117

TimBarham opened this issue Jul 20, 2016 · 2 comments · Fixed by #140
Assignees
@albertinad

Comments

@TimBarham
Copy link
Contributor

Some browsers (Chrome for example) validate the value of a numeric input field based on the value of step. Since this defaults to 1, and we never specify it for cordova-number-entry elements, any non-integer value is flagged as an error. For example, the tooltip for the Latitude field of the Geolocation panel shows something like the following error:

Please enter a valid value. The two nearest valid values are 43 and 44.
@TimBarham TimBarham assigned TimBarham and albertinad and unassigned TimBarham Jul 20, 2016
@TimBarham
Copy link
Contributor Author

BTW in Firefox these are shown visually as being in an error state:

image

@albertinad
Copy link
Collaborator

Yes, I noticed that too. I will fix this. Thanks!

@albertinad albertinad mentioned this issue Aug 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertinad albertinad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure "step" attribute of all cordova-input-number used. microsoft/cordova-simulate
2 participants
@albertinad @TimBarham