Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No separation between sent and sending events #1155

Open
NN--- opened this issue May 29, 2023 · 1 comment
Open

No separation between sent and sending events #1155

NN--- opened this issue May 29, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@NN---
Copy link

NN--- commented May 29, 2023

EVT_SENT and EVT_SENDING both have the same value.
The event is triggered before the data is actually sent.
There should be different value for two events where EVT_SENDING is triggered before the data is sent and EVT_SEND only after the data has been sent.

        /// <summary>Event(s) sent.</summary>
        EVT_SENT                = 0x04000000,
        /// <summary>Event(s) being uploaded.</summary>
        EVT_SENDING             = 0x04000000,

@NN--- NN--- added the bug Something isn't working label May 29, 2023
@maxgolov
Copy link
Contributor

maxgolov commented Sep 13, 2023

It's sort of design intent. There used to be EVT_SENT constant in the older Aria SDK. The new SDK keeps track of the moment the batch is sent for async processing, with no confirmation when the batch actually receives 200 OK. There is a case where there will be multiple retries, if one attempt fails, and there's no cross-reference back to individual events included in the batch. Best you can do is keep track of EVT_SENDING, and the HTTP status code callbacks, operating based on how many batches got 200 OK EVT_HTTP_OK. Fixing this won't be trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants