-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup core SDK build agent that is similar to Edge gn setup #16
Comments
There's also a task on me to clean up some suppressed warnings. This might make more sense to do once our set of ignored warnings is a lot smaller. Ideally, I'd also like to move our GN build file into this repo too, but I'm not sure how easy it is to set up GN outside of Chromium projects. These are the internal suppressed warnings we have: |
Unfortunately realistically we won't be able to tackle this at least until the end of August. Help is appreciated in this regard, to comment on how we can setup the builds for that using GitHub repo as source. |
GitHub-CI now has the rules to use ./build.sh (cmake) on Linux and Mac, plus hosted Azure Pipeline builds on Windows. If you can contribute a build file that utilizes 'gn' tool to build, like build-gn.sh or build-gn.cmd or a build flag to existing build scripts to use ninja, that would be greatly appreciated. Meanwhile I'd have to reforecast this to September. |
We have a deliverable to track work on adding automated tests for OneDS building with GN. Will discuss it on Friday in planning. |
@bliptec - I'm going thru the old backlog items. Currently we don't have GN setup... Unless it "might" work if we generate the GN build files from CMakeLists.txt... But I don't think we have cycles to spend on this. I'm suggesting to close this item. For now we rely on CMake + make and/or msbuild only. No GN. |
@bliptec - this one is stale. I know you guys have your own setup for that. I don't think currently we want to replicate this in our own CI. I'm closing it as |
I'm reopening it, but with slightly adjusted goal in mind:
This should be more or less 95% functionally similar to |
Closing due to inactivity. Feel free to reopen. No plans to fix. Best solution would be to set up the usual cmake+ninja build (not gn). |
Currently 1DS SDK is not built with the same set of compiler dependencies and warning levels as MS Edge. It would help if we can clean up OneDS warnings & Integrate a CI target with a very similar build setup to that of MS Edge (Windows clang-cl, Mac/Linux clang with strict warnings), with continuous run of BVT (unit and functional). That way all potential breaking issues can be caught early-on prior integrating a new SDK source code drop in MS Edge.
The text was updated successfully, but these errors were encountered: