Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MSP bitmask on wire via common properties API #25

Closed
maxgolov opened this issue Jun 18, 2019 · 7 comments
Closed

Expose MSP bitmask on wire via common properties API #25

maxgolov opened this issue Jun 18, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request OTEL Partner Team - Microsoft Office Telemetry team

Comments

@maxgolov
Copy link
Contributor

This ask comes from Office Desktop telemetry.

The new MSP flags / bitmask field allows to determine what ring / group the user belongs to; also allows to enable routing of a subset of data to Enterprise Data Platform.

Requirements:

  • allow the customer to set MSP flags via API call at individual event-level (SetProperty or SetContext)
  • send MSP flag on wire in Bond 3.0+ schema to Collector++
@maxgolov maxgolov added the enhancement New feature or request label Jun 18, 2019
@maxgolov maxgolov added this to the Vibranium - 07.July milestone Jun 18, 2019
@maxgolov maxgolov self-assigned this Jun 18, 2019
@maxgolov maxgolov added the OTEL Partner Team - Microsoft Office Telemetry team label Jun 24, 2019
@maxgolov
Copy link
Contributor Author

Further clarity needed from OTEL team if they believe this item is required.
On-hold - pending review.

@maxgolov
Copy link
Contributor Author

Retarget to August.

@maxgolov
Copy link
Contributor Author

Retarget to September, as we had no feedback from OTEL if this is still required.

@maxgolov
Copy link
Contributor Author

#118 will add a way for the app to populate the MSP bitmask. SDK does not know how to fetch nor what registry keys to use for that. It is the app that should identify the target audience, set the bits and use a custom decorator on matching events to route these to EDP using MSP bits. Sample app with a custom decorator will be provided.

@maxgolov
Copy link
Contributor Author

maxgolov commented Mar 5, 2020

No timeline. Logged documentation issue against CS4.0:
https://github.com/microsoft/common-schema/issues/21

@maxgolov
Copy link
Contributor Author

maxgolov commented Mar 31, 2020

Based on feedback from Office teams - this is not a priority at least until the end of April 2020.

@maxgolov
Copy link
Contributor Author

maxgolov commented Jul 14, 2020

MSP bit added in Common Schema 4.0 CsEvent in #118 . It can be populated using Custom Decorator, which was also added in this PR. I'm closing this issue until some team explicitly asks for MSP support, other than based on Custom Decorator approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OTEL Partner Team - Microsoft Office Telemetry team
Projects
None yet
Development

No branches or pull requests

1 participant