Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename C# projection outputs to remove the dash #38

Closed
botrif opened this issue Jul 12, 2019 · 4 comments
Closed

Rename C# projection outputs to remove the dash #38

botrif opened this issue Jul 12, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request MRW Partner Team - Mixed Reality for Work

Comments

@botrif
Copy link
Contributor

botrif commented Jul 12, 2019

The DLL and PDB filenames contain "Windows-Managed", and if they're included in a C# project as content (as only the winmd file is included as a reference), Visual Studio interprets the dash in the filename as a language name (just like with en-US), and generates a warning during packaging since the app doesn't actually support such as "language"

@maxgolov maxgolov added the enhancement New feature or request label Jul 12, 2019
@maxgolov maxgolov added this to the Vibranium - 08.August milestone Jul 12, 2019
@maxgolov
Copy link
Contributor

Need to notify our partners who might have been using this with an old .dll name(s). It'd make sense to consistently rename the .dll for all platforms, using the following naming convention:

  • Microsoft.Applications.Telemetry.Windows.UWP - for Universal Store apps, expose WinRT-style platform types.

  • Microsoft.Applications.Telemetry.Windows.native - for Universal Store apps written in C++ only, light SDK flavor that does not include WinRT-style projection - we expose STL projection. That is the flavor used by Outlook Universal store and Office, so we need to notify them about the renaming from dash to dot accordingly.

  • Microsoft.Applications.Telemetry.Windows.NET - for .NET 4.0 framework, expose C# system types.

@maxgolov
Copy link
Contributor

@mkoscumb @kindbe - this .dll renaming may affect Office immersive apps packaging. If you have objections on this, we can keep -native suffix for native C++ .dll

@maxgolov maxgolov added the MRW Partner Team - Mixed Reality for Work label Jul 12, 2019
@mkoscumb
Copy link
Contributor

Shouldn't be too bad for Office. We consume the 1DS C++ SDK from static source drops or via NuGet drops. I'll give a head's up to the teams that consume the SDK.

@maxgolov
Copy link
Contributor

Fixed / Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MRW Partner Team - Mixed Reality for Work
Projects
None yet
Development

No branches or pull requests

4 participants