-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2KB memory leak found with Mac leaks
tool
#744
Comments
I have a few questions about the tooling used in this scenario:
Ref.: https://developer.apple.com/forums/thread/73588 Cit: The "Leaks" instrument is famous for being inccurate (both false positives and false negatives), We need to decide on the priority of it: is it possible to have a longer stress-test, with a larger document being open and edited for 10-15+ minutes, do you observe more than 2KB leak from SDK in this case? I'd say 2KB leak is minor and non-service impacting, thus lower priority. However, if we observe a larger leak in a stress - that is worrisome. I'd also like to have this tackled in a different way: measuring the core layer only, i.e. standalone 1DS C++ SDK, no Obj-C projection - using tcmalloc (although results may differ). I am working in PR which will add it: #721 It is important to take a carefully weighted approach on this, avg of:
Note that ILogger objects are leaky by-design: That'd be adding up to at least 512+ bytes, if not 1KB out of 2K. This leak is "design intent" to avoid crashes in "use after free" scenarios. |
Related to #634 |
Word is single process, no new process is spin when creating a new document. Please note Leaks currently reports leaks on few other places (not related to Aria) as well; leaked amount by Aria SDK is not severe, so bug is not high priority. |
If you don't mind, I'll change the title :) |
leaks
tool
Three of the strings called out in the example report are keys in a configuration object. I would certainly expect the configuration maps themselves to allocate before the first document open and outlive any number of documents in a single Word session. The OTel stack will have set configuration during liblet init, and won't do anything at all about tearing things down until liblet uninit, and this is consistent across all platforms (of course, since it's shared C++ code). |
ARIA SDK seems to be leaking memory while running Mac Office apps.
Repro steps:
Launch Word final stage/relese build to a blank doc (turn off docstage)
Close doc and create a new one
type "leaks {processID}
Expected Results:
No leaks reported from 1DS related code paths
Current Results:
Aria is leaking 2kb of memory
The text was updated successfully, but these errors were encountered: