Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Feedback #14

Open
swang206 opened this issue Sep 18, 2021 · 0 comments
Open

Feedback #14

swang206 opened this issue Sep 18, 2021 · 0 comments

Comments

@swang206
Copy link

swang206 commented Sep 18, 2021

  1. Too many static in header files. They should be "inline", instead of static. The inline means the compiler should discard duplicated symbols. If you use static, it bloats the functions for every translation unit.
    https://devblogs.microsoft.com/oldnewthing/20200521-00/?p=103777
  2. It looks like some functions are no marks in headers. That violates ODR and makes compilation impossible.
  3. We cannot use anything that relates to iostream, including filesystem. iostream introduces dead virtual functions in the binary that bloats a lot of binary size.
  4. include<windows.h>. Windows.h is a large header file. It is extremely slow. The correct way is of course to declare functions by yourself and then use linker comments to link against them.
  5. Even std::string, std::array need to be used carefully because they bloat compilation time. Particularly std::string
@kennykerr kennykerr changed the title Rant: I do not like this project. Feedback Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant