Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract away column names in frame generation functions #14

Closed
jhofman opened this issue Apr 7, 2021 · 2 comments
Closed

Abstract away column names in frame generation functions #14

jhofman opened this issue Apr 7, 2021 · 2 comments
Assignees
@giorgi-ghviniashvili
Labels
javascript rendering-animations has to do with rendering an animation

Comments

@jhofman
Copy link
Contributor

jhofman commented Apr 7, 2021

Right now the specific "salary" and "degree" column names are used inside of the frame generation functions in d3. If we end up going with our own d3 code for generating frames we'll need to abstract this away to "x" and "y" and have some way to pass which column names map to which variables when calling r2d3.

Let's put this on hold until we figure out #12.
@jhofman
Copy link
Contributor Author

jhofman commented Apr 13, 2021

@giorgi-ghviniashvili seems like this will be solved if we go with vegalite + gemini.

assuming so, let's close this out?

@jhofman jhofman added rendering-animations has to do with rendering an animation javascript labels Apr 13, 2021
@sharlagelfand
Copy link
Collaborator

Definitely solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giorgi-ghviniashvili giorgi-ghviniashvili

Labels
javascript rendering-animations has to do with rendering an animation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhofman @giorgi-ghviniashvili @sharlagelfand