Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points moving across facets #48

Closed
sharlagelfand opened this issue May 12, 2021 · 6 comments
Closed

Points moving across facets #48

sharlagelfand opened this issue May 12, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@sharlagelfand
Copy link
Collaborator

@giorgi-ghviniashvili I haven't been able to figure out why points are moving across facets - as far as I can tell the IDs match! Could you take a look? The example in #47 shows it and also this one in the app with dataset: penguins and group by: species, island, sex:

flying_axes.mov

The specs for this case are here.

Thanks!!

@sharlagelfand sharlagelfand added the bug Something isn't working label May 12, 2021
@giorgi-ghviniashvili
Copy link
Collaborator

@sharlagelfand found one issue: Adelie and Torgersen has 5 NA points, while jitter one has 4:

image

@sharlagelfand
Copy link
Collaborator Author

@giorgi-ghviniashvili one of the Y values is actually NA (/null) so it shouldn't show up in the jittering - is it possible to have that point shown in the infogrid then "disappear" when move to jittering?

I have it worked out so the ID of the NA one isn't in the specs (here - there is id 147 and 149, but no 148 since that value is missing), but maybe that's not how gemini actually works - thought it might pick up the ID being gone between frames and fade it out?

@giorgi-ghviniashvili
Copy link
Collaborator

@sharlagelfand it should work like you describe, the point with id 148 should be gone in exit selection of d3, but needs a bit more exploration why it does not work like that. Will dive into it.

@giorgi-ghviniashvili
Copy link
Collaborator

@sharlagelfand I found the issue. The gemini's recommendations did not correctly generate the animation spec. I manually updated gem spec for third frame and got this:

third-frame.mov

In general, I should come up with general solution.

@giorgi-ghviniashvili
Copy link
Collaborator

@sharlagelfand It is not a bug with the gemini, but the initialization object (my fault!). I modified it and now it correctly recommends. It was not correctly setting gemini_id.

@sharlagelfand
Copy link
Collaborator Author

thank you!!! looks good 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants