-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GotoTarget lifetime #39
Comments
My suggested documentation: Ids are valid until the next continue. If multiple |
Could someone explain a use-case for doing multiple GotoTargetsRequests in a row? I can barely come up with an example for returning more than 1 target (template functions come to mind but why would it be ambiguous if you are already in the same function) let alone multiple target requests. |
I am not sure why a client might want to issue multiple
FYI: If you are asking about this because you are thinking about implementing this in MIEngine, |
I guess confusion about the spec like in this ticket, vscode as the reference implementation does it as described above and it makes the implementation much easier (at least if you assume IDs need to be globally unique, that crucial 'certain IDs are valid only until the next continue' information is buried in some tickets on Github, see #60).
Interesting. Related to #38.
I see, should be added to the docs. |
For compiled languages, I think of the
|
Yeah it's easy to handle breakpoints as for example gdb just sets 1 per associated address. But |
If you want to implement jumping by dragging the current line marker like in VS you'd probably have to do that. |
The specification does not define the lifetime of a
GotoTarget
as obtained from a givenGotoTargetsRequest
, so it is unclear if it's legal for an IDE to cache them and reuse them later (possibly acrossgoto
, acrosscontinue
, or in different frames that just happen to use the same source), or whether the adapter can clean up associated resources more aggressively - e.g. on invalidate them on everygoto
.It's also unclear whether the adapter can return different IDs for the same file/line on a subsequent request, even if it ensures that old IDs are still valid to use in
goto
- and if it can do so, then how should the IDE interpret this.The text was updated successfully, but these errors were encountered: