Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect if init distributed is needed #85

Closed
jeffra opened this issue Feb 15, 2020 · 1 comment · Fixed by #108
Closed

Detect if init distributed is needed #85

jeffra opened this issue Feb 15, 2020 · 1 comment · Fixed by #108
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jeffra
Copy link
Contributor

jeffra commented Feb 15, 2020

Ideally we could remove the init_dist_required flag from deepspeed initialize if we can detect if it’s already been started. This can prevent some types of bugs like in #65
@jeffra jeffra added the enhancement New feature or request label Feb 15, 2020
@ShadenSmith ShadenSmith added the good first issue Good for newcomers label Feb 15, 2020
@jeffra jeffra changed the title Detect if init distributed if needed Detect if init distributed is needed Feb 21, 2020
@jeffra
Copy link
Contributor Author

jeffra commented Feb 21, 2020

https://pytorch.org/docs/stable/distributed.html#torch.distributed.is_initialized

@ShadenSmith ShadenSmith mentioned this issue Feb 23, 2020
Closed
@jeffra jeffra mentioned this issue Feb 26, 2020
Merged
@jeffra jeffra linked a pull request Feb 26, 2020 that will close this issue
Init distributed torch only if needed #108
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Init distributed torch only if needed microsoft/DeepSpeed
2 participants
@ShadenSmith @jeffra