Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inetstack] Rely on SocketAddr enum Rather Than SocketAddrV4 struct #204

Open
ppenna opened this issue Mar 29, 2022 · 4 comments
Open

[inetstack] Rely on SocketAddr enum Rather Than SocketAddrV4 struct #204

ppenna opened this issue Mar 29, 2022 · 4 comments
Labels
bug Something Isn't Working confirmed Issue Affects Multiple People good first issue Good for Newcomers
Milestone
Demikernel v1.5 (...

Comments

@ppenna
Copy link
Contributor

ppenna commented Mar 29, 2022 •
edited by BrianZill
Loading

Description

Catnip uses the Ipv4Endpoint SocketAddrV4 structure to refer to remote and local endpoints. While this is fine when supporting IPv4 addresses only, once we add support to IPv6 it is make the stack a mess. Therefore, we should change the stack so as to refer to local and remote endpoints using a more generic type, like IpEndpointSocketAddr.
@ppenna ppenna added bug Something Isn't Working good first issue Good for Newcomers confirmed Issue Affects Multiple People labels Mar 29, 2022
@gatoWololo
Copy link
Contributor

Maybe something like std::net::SocketAddr from the standard library?

@BrianZill
Copy link
Contributor

Maybe something like std::net::SocketAddr from the standard library?

Yes, our Ipv4Endpoint is broken. See Issue demikernel/inetstack#172.

@BrianZill BrianZill changed the title [ip] Rely on an IpEndpoint Structure Rather than Ipv4Endpoint [ip] Rely on SocketAddr enum Rather Than SocketAddrV4 struct Jun 14, 2022
@BrianZill
Copy link
Contributor

BrianZill commented Jun 14, 2022 •
edited
Loading

Since we removed the Ipv4Endpoint struct and replaced it with SocketAddrV4 (in PR demikernel/inetstack#177), I updated the title and description to reflect this.

@ppenna ppenna self-assigned this Jun 14, 2022
@ppenna ppenna assigned anandbonde and unassigned anandbonde and ppenna Jul 27, 2022
@ppenna ppenna mentioned this issue Jul 28, 2022
Closed
@anandbonde anandbonde mentioned this issue Aug 22, 2022
Merged
@ppenna ppenna transferred this issue from another repository Sep 9, 2022
@ppenna
Copy link
Contributor Author

ppenna commented Dec 2, 2022

@anandbonde are we done with this?

@ppenna ppenna changed the title [ip] Rely on SocketAddr enum Rather Than SocketAddrV4 struct [inetstack] Rely on SocketAddr enum Rather Than SocketAddrV4 struct Apr 5, 2023
@ppenna ppenna added this to the Demikernel v1.5 milestone Apr 5, 2023
This was referenced Sep 12, 2023
Closed
Open
Merged
@ppenna ppenna self-assigned this Jan 5, 2024
@ppenna ppenna removed their assignment Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something Isn't Working confirmed Issue Affects Multiple People good first issue Good for Newcomers
Projects
None yet
Milestone
Demikernel v1.5 (Stable Catpowder LibOS)
Development

No branches or pull requests
4 participants
@anandbonde @ppenna @gatoWololo @BrianZill