Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdpix] Support Scatter-Gather Arrays with Multiple Segments #88

Open
ppenna opened this issue Apr 13, 2022 · 3 comments
Open

[pdpix] Support Scatter-Gather Arrays with Multiple Segments #88

ppenna opened this issue Apr 13, 2022 · 3 comments
Assignees
Labels
feature New Feature Request

Comments

@ppenna
Copy link
Contributor

ppenna commented Apr 13, 2022

Description

Demikernel currently has the limitation of single-segment scatter-gather arrays:

#define DMTR_SGARRAY_MAXSIZE 1

...

typedef struct dmtr_sgarray {
    void *sga_buf;
    uint32_t sga_numsegs;
    dmtr_sgaseg_t sga_segs[DMTR_SGARRAY_MAXSIZE];
    // todo: to be removed when LWIP libOS is retired in favor of
    // `dpdk-catnip`.
    struct sockaddr_in sga_addr;
} dmtr_sgarray_t;

We should support the creation of scatter-gatther arrays with multiple segments.

@ppenna ppenna added bug Something Isn't Working confirmed Issue Affects Multiple People labels Apr 13, 2022
@ppenna ppenna changed the title [PDPIX] Support Scatter-Gather Arrays with Multiple Segments [pdpix] Support Scatter-Gather Arrays with Multiple Segments May 22, 2022
@JayjeetAtGithub
Copy link

I am interested in fixing this issue since this is something I would like to use for a different project. Any pointers on how to approach will be great.

@ppenna
Copy link
Contributor Author

ppenna commented Oct 26, 2022

Hello @JayjeetAtGithub this change requires:

  • Changing the layout of data structures
  • Changing the code of all libOses to handle the proper allocation of multiple-segment scatter gather arrays.

I would recommend you start with Catnap, which is easier to fix.

@JayjeetAtGithub
Copy link

Okay, I will try to raise a PR soon. Thanks.

@ppenna ppenna added feature New Feature Request and removed bug Something Isn't Working confirmed Issue Affects Multiple People labels Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants