Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing map from contextual hover menu should not close map peek #2

Open
TheLarkInn opened this issue Mar 14, 2023 · 3 comments
Open
Labels
external Relates to another program, environment, or user action which we cannot control.

Comments

@TheLarkInn
Copy link
Member

image

Current behavior:
If I click on a Map links in this hover menu, a "map peek" opens.
Then if I click on the next Map link, the "map peek" closes.

Expected behavior:
If I click on a Map links in this hover menu, a "map peek" opens.
Then if I click on the next Map link, the "map peek" should stay open and just load the new map which was clicked.

@rbuckton
Copy link
Member

This seems to be the intended behavior of a peek:

https://github.com/microsoft/vscode/blob/572ccd1fff89a1aa4494d13ea8399d638634f536/src/vs/editor/contrib/gotoSymbol/browser/peek/referencesController.ts#L76-L84

The only way to keep the peek open is if the position you pass to 'editor.action.showReferences' (or, I guess it's now 'editor.action.peekLocations') differs from the previous time it was opened, as long as the peek is still open.

@mjbvz: do you know if that is intentional, or if there's a more reliable way around this behavior?

@TheLarkInn
Copy link
Member Author

In this specific scenario I like being able to see how the Map's transition/change so closing and reopening breaks that focusing context.

Perhaps maybe we should introduce a separate way to show how Maps transition.

@mjbvz
Copy link

mjbvz commented May 15, 2023

@jrieken: You know more about the references support in VS Code. Can you please help Ron out with this issue?

@rbuckton rbuckton added the external Relates to another program, environment, or user action which we cannot control. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Relates to another program, environment, or user action which we cannot control.
Projects
None yet
Development

No branches or pull requests

3 participants