Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Monaco Adapter unit tests to be async #9

Open
janechu opened this issue Apr 16, 2021 · 0 comments
Open

Convert Monaco Adapter unit tests to be async #9

janechu opened this issue Apr 16, 2021 · 0 comments
Assignees
@janechu
Labels
2 Estimate (days) area:environment Pertains to the development environment category:stability Enhancing stability by updating underlying dependencies/code or adding testing mechanisms chore Maintenance or non-code work
Projects
Tooling
Milestone
3

Comments

@janechu
Copy link
Contributor

janechu commented Apr 16, 2021

Description

The tests for the Monaco Adapter service must be async or they will cause other tests to not be run, or to throw errors.

Requirements

  • Convert the tests in monaco-adapter.service.spec.ts to async and ensure the tests do not skip over other tests
  • Remove the file from the ignore glob in karma.conf.js
@janechu janechu self-assigned this Apr 16, 2021
@janechu janechu transferred this issue from microsoft/fast Jul 12, 2021
@janechu janechu added area:environment Pertains to the development environment chore Maintenance or non-code work labels Jul 12, 2021
@janechu janechu added this to Triage in Tooling via automation Jul 12, 2021
@janechu janechu moved this from Triage to Backlog in Tooling Jul 12, 2021
@janechu janechu added the category:stability Enhancing stability by updating underlying dependencies/code or adding testing mechanisms label Sep 13, 2021
@janechu janechu mentioned this issue Oct 4, 2021
Open
@janechu janechu added this to the 2 milestone Nov 9, 2021
@janechu janechu added the 2 Estimate (days) label Nov 9, 2021
@janechu janechu moved this from Backlog to To do in Tooling Jan 5, 2022
@janechu janechu modified the milestones: 2, 3 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janechu janechu

Labels
2 Estimate (days) area:environment Pertains to the development environment category:stability Enhancing stability by updating underlying dependencies/code or adding testing mechanisms chore Maintenance or non-code work
Projects
Tooling
To do
Milestone
3
Development

No branches or pull requests
1 participant
@janechu