Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the IPluginAdaptiveCard's template parameter name in Update in Microsoft.Windows.DevHome.SDK.PluginUI.idl #10

Closed
adrastogi opened this issue Mar 8, 2023 · 0 comments · Fixed by #62
Closed

Change the IPluginAdaptiveCard's template parameter name in Update in Microsoft.Windows.DevHome.SDK.PluginUI.idl #10

adrastogi opened this issue Mar 8, 2023 · 0 comments · Fixed by #62
Assignees
@ujjwalchadha
Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Milestone
Dev Home v0.1

Comments

@adrastogi
Copy link
Contributor

adrastogi commented Mar 8, 2023 •
edited

Dev Home version

1.0.0.0

Windows build number

10.0.23411.1000

Other software

OS Build Version: 10.0.23411.1000.amd64fre.ni_moment_directadept.230306-1233
.NET Version: .NET 6.0.14

Steps to reproduce

Try to consume the DevHome SDK's .winmd file from a C++/WinRT application in Visual Studio.

Expected behavior

The application can be compiled successfully.

Actual behavior

The header file that is generated from the .winmd contains syntax errors. This is because the IPluginAdaptiveCard's Update method contains a C++ language keyword.

image

Included System Information

CPU: AMD Ryzen Threadripper PRO 3945WX 12-Cores
Physical Memory: 68.57GB (43.15GB free)
Processor Architecture: x64
@adrastogi adrastogi added the Issue-Bug Something isn't working or needs investigation label Mar 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Mar 8, 2023
@adrastogi adrastogi changed the title Change the IPluginAdaptiveCard's parameter name in Microsoft.Windows.DevHome.SDK.PluginUI.idl Change the IPluginAdaptiveCard's template parameter name in Microsoft.Windows.DevHome.SDK.PluginUI.idl Mar 8, 2023
@adrastogi adrastogi changed the title Change the IPluginAdaptiveCard's template parameter name in Microsoft.Windows.DevHome.SDK.PluginUI.idl Change the IPluginAdaptiveCard's template parameter name in Update in Microsoft.Windows.DevHome.SDK.PluginUI.idl Mar 8, 2023
@ujjwalchadha ujjwalchadha mentioned this issue Mar 19, 2023
Merged
@krschau krschau added Resolution-Fix-Available Available in a release and removed Needs-Triage New issue that the core contributors need to triage labels May 30, 2023
@krschau krschau added this to the Dev Home v0.1 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ujjwalchadha ujjwalchadha

Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Projects
None yet
Milestone
Dev Home v0.1
Development

Successfully merging a pull request may close this issue.

AdaptiveCard templating support for Plugin microsoft/devhome
3 participants
@adrastogi @krschau @ujjwalchadha