Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing localization in SummaryView #1670

Closed
krschau opened this issue Oct 9, 2023 · 0 comments · Fixed by #2730
Closed

Missing localization in SummaryView #1670

krschau opened this issue Oct 9, 2023 · 0 comments · Fixed by #2730
Assignees
@dhoehna
Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Summary Related to the summary page after machine config flow Issue-Bug Something isn't working or needs investigation Priority-3 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release
Milestone
Dev Home v0.14

Comments

@krschau
Copy link
Contributor

krschau commented Oct 9, 2023

Dev Home version

0.5

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Multiple strings in SummaryView.xaml.cs are not localized. See this comment: #1632 (comment)

Expected result

All strings visible to the user should be localized.

Actual result

A few strings are not localized.

Included System Information

No response

Included Extensions Information

No response
@krschau krschau added the Issue-Bug Something isn't working or needs investigation label Oct 9, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Oct 9, 2023
@krschau krschau added Area-Machine-Config Related to the machine configuration feature and removed Needs-Triage New issue that the core contributors need to triage labels Oct 9, 2023
@krschau krschau mentioned this issue Oct 9, 2023
Merged
3 tasks
@kanismohammed kanismohammed added Priority-3 Area-Machine-Config-Summary Related to the summary page after machine config flow labels Nov 7, 2023
@dhoehna dhoehna mentioned this issue Apr 23, 2024
Merged
3 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 23, 2024
@krschau krschau added Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release and removed In-PR This issue has a related PR labels Apr 24, 2024
@krschau krschau added this to the Dev Home v0.14 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhoehna dhoehna

Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Summary Related to the summary page after machine config flow Issue-Bug Something isn't working or needs investigation Priority-3 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release
Projects
None yet
Milestone
Dev Home v0.14
Development

Successfully merging a pull request may close this issue.

Localizing strings in the summary page microsoft/devhome
3 participants
@dhoehna @krschau @kanismohammed