Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox icon is missing and thumbnail is the wrong size #3162

Closed
cinnamon-msft opened this issue Jun 6, 2024 · 6 comments
Closed

Sandbox icon is missing and thumbnail is the wrong size #3162

cinnamon-msft opened this issue Jun 6, 2024 · 6 comments
Assignees
Labels
Area-Environments Issue-Bug Something isn't working or needs investigation Priority-1 Resolution-By-Design This is intended to be implemented this way
Milestone

Comments

@cinnamon-msft
Copy link
Contributor

cinnamon-msft commented Jun 6, 2024

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Have Windows Sandbox enabled
Navigate to environments page

Expected result

The thumbnail image should be the same size as the others and there should be an icon to the left of "Windows Sandbox"

Actual result

Looks like the thumbnail is at a different aspect ratio and there's no icon:
image

Included System Information

No response

Included Extensions Information

No response

@cinnamon-msft cinnamon-msft added the Issue-Bug Something isn't working or needs investigation label Jun 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Jun 6, 2024
@cinnamon-msft cinnamon-msft changed the title Sandbox thumbnail is the wrong size Sandbox icon is missing and thumbnail is the wrong size Jun 6, 2024
@bbonaby
Copy link
Contributor

bbonaby commented Jun 6, 2024

@cinnamon-msft Can you check if you have multiple versions of Dev Home installed like the Dev version and the Canary version? If so can you make sure the sandbox extension for the dev version is turned off. That might fix the icon missing issue. I do believe I've seen the icon showing up before.

About the thumbnail: @pehammer would either you or Christian be able to get us a new image for sandbox scaled appropriately just like we did for Hyper-V and Dev Box? Looks like we're using the light version of bloom here for sandbox

@cinnamon-msft
Copy link
Contributor Author

I don't have a Dev version on this machine, just Preview and Canary, and Preview doesn't have Sandbox yet

@bbonaby
Copy link
Contributor

bbonaby commented Jun 6, 2024

Sounds good thanks Kayla just wanted to make sure it wasn't one of those multiple dev home version issues. Would you also be able to add the sandbox log file and the dev home log file to this issue as well when you can thanks!

@cinnamon-msft
Copy link
Contributor Author

Here you go!
devhome20240606.zip

@bbonaby
Copy link
Contributor

bbonaby commented Jun 6, 2024

Thanks, looks like the issue is that the build constants are not present in the sandbox project e.g for Hyper-V:

we have this line in the csproj file. It declares STABLE_BUILD and CANARY_BUILD as constants for the project. The Sandbox uses these same constants in this file just like we do for HyperV here. However since those constants aren't declared in the sandbox csproj file, the ifdef's go into the else case, where it looks for this file:

ms-resource://microsoft.windows.devhome.dev/Files/Assets/windows-sandbox-icon.png

and you'll notice that the package its using is microsoft.windows.devhome.dev , which like you said above doesn't exist on your machine. So therefore an image isn't found.

This should be a simple fix though, we just need to declare those constants in the sandbox csproj file in here somewhere: https://github.com/microsoft/devhome/blob/9db92955056f1be932ee500c876b6f62ff626c3b/extensions/WindowsSandboxExtension/WindowsSandboxExtension.csproj

@kanismohammed kanismohammed removed the Needs-Triage New issue that the core contributors need to triage label Jun 7, 2024
@kanismohammed kanismohammed added this to the Dev Home 0.15 milestone Jun 10, 2024
@krschau
Copy link
Contributor

krschau commented Jun 11, 2024

Sandbox extension has been removed, so this issue is no longer applicable.

@krschau krschau closed this as completed Jun 11, 2024
@krschau krschau added the Resolution-By-Design This is intended to be implemented this way label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Environments Issue-Bug Something isn't working or needs investigation Priority-1 Resolution-By-Design This is intended to be implemented this way
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants