Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Connect to Github" button on "What's New" page doesn't have any apparent effect? #76

Closed
adrastogi opened this issue Mar 22, 2023 · 2 comments · Fixed by #80
Closed
Assignees
Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Milestone

Comments

@adrastogi
Copy link
Contributor

Dev Home version

1.0.0.0

Windows build number

10.0.23420.1000

Other software

OS Build Version: 10.0.23420.1000.amd64fre.ni_moment_directadept.230317-1531
.NET Version: .NET 6.0.15

Steps to reproduce

  1. Install the GitHub package and DevHome package from the 3/17 self-host mail.
  2. Launch DevHome and click the 'Connect to Github' button on the 'What's New' page

Expected behavior

I was expecting some sort of account connection flow to get initiated.

Actual behavior

Nothing, as far as I can tell.

(There's also a spelling nit IMO on the button- I think 'Github' should be cased as 'GitHub'.)

Included System Information

CPU: 11th Gen Intel(R) Core(TM) i7-11370H @ 3.30GHz
Physical Memory: 34.18GB (20.19GB free)
Processor Architecture: x64

@adrastogi adrastogi added the Issue-Bug Something isn't working or needs investigation label Mar 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Mar 22, 2023
@vineeththomasalex
Copy link
Contributor

The wiring hasn't been added for this button. Taking this.

@vineeththomasalex
Copy link
Contributor

Closing this bug. Verified #80 fixes this for now.

@krschau krschau added Resolution-Fix-Available Available in a release and removed Needs-Triage New issue that the core contributors need to triage labels May 30, 2023
@krschau krschau added this to the Dev Home v0.1 milestone Jun 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 19, 2023
@krschau krschau removed the In-PR This issue has a related PR label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working or needs investigation Resolution-Fix-Available Available in a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants