Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Home GitHub Extension: More GitHub instance type support needed & more information needed to help people sign-in correctly #813

Closed
JustinGOSSES opened this issue May 24, 2023 · 3 comments
Assignees
Labels
Area-Account-Sign-In Related to authenticating with extensions Issue-Feature New feature or request Resolution-Duplicate This issue or pull request already exists

Comments

@JustinGOSSES
Copy link

Suggested new feature or improvement

(1) Need to be able to sign into GitHub EMU and GitHub Enterprise Server and get data into DevHome.
(2) Developers need to be able to see repository information organized by GitHub instance type & accounts.
(3) It needs to be very clear what username is being used to sign-in as the current approach merely opens the default browser and whatever GitHub account was last active there will be what is signed into. If a sign-in has already occurred in recent past, the browser seems to skip the page that tells you what instance and account you are signing into. It merely says "you are signed in and can go back to DevHome". This occurs even if you have already signed out on DevHome side. This leads to a confusing user experience. It would be helpful to have more information related to this BOTH before clicking "sign-in" and after "sign-in" is complete. Perhaps a "how to sign-in to multiple accounts or instances" helper information at a link?

Scenario

It is common for people in an enterprise to have multiple GitHub accounts for different instances of GitHub or even different users for the same instance in less common situations. Instances can include GitHub public, GitHub EMU, GitHub Server, etc. In some cases, the same username might be used across different instances but different login URLs.

Given developers work occurs across these instances, all should be supported and it should be clear where each repository issue or PR notification comes from.

Additional details

Currently (2023-05-24), it is possible to sign-in to GitHub EMU successfully on DevHome but no data shows up. Ideally, there would be a message about GitHub EMU not being supported after sign-in.

@JustinGOSSES JustinGOSSES added the Issue-Feature New feature or request label May 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 24, 2023
@mathewleeza mathewleeza added Area-Extensibility Related to extensions Area-Account-Sign-In Related to authenticating with extensions and removed Area-Extensibility Related to extensions labels May 26, 2023
@dgitw
Copy link

dgitw commented May 26, 2023

+1 Github Enterprise Server with Azure AD Creds

@mikebattista
Copy link

You should be able to sign into GitHub EMU today through the browser, but only 1 account at a time like with other clients.

GitHub Enterprise Server is on the roadmap. See #825.

Support for multiple accounts is also on the roadmap but requires dependent work from GitHub before we can enable. All other clients behave the same way today supporting 1 account at a time.

@jamespik jamespik added Priority-1 and removed Needs-Triage New issue that the core contributors need to triage labels Jun 5, 2023
@mathewleeza mathewleeza added this to the Backlog milestone Jun 13, 2023
@krschau
Copy link
Contributor

krschau commented Nov 14, 2023

As Mike mentioned, Enterprise Server is tracked by 825, and multiple accounts is tracked by microsoft/devhomegithubextension#276. (There are updates in that one, so I'm going to leave it open, even though it's slightly newer than this one)

@krschau krschau closed this as completed Nov 14, 2023
@krschau krschau added the Resolution-Duplicate This issue or pull request already exists label Nov 14, 2023
@krschau krschau removed this from the Backlog milestone Nov 14, 2023
@vineeththomasalex vineeththomasalex self-assigned this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Account-Sign-In Related to authenticating with extensions Issue-Feature New feature or request Resolution-Duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

7 participants