Arduino installation failed due to the bogus output parsing design

[reyang]

This is the wrong way of doing things - we should not try to parse the command ouput, instead we want to check the return code (e.g. %ERRORLEVEL% == 0).

[helenlivsc]

To know more info about the error, can you take the followings?

1. Open a command window
2. Expand to path c:\program files (x86)\Arduino
3. Run the command Arduino_debug.exe then capture a screenshot to attach here
4. Run the exact command in the screenshot above then capture a screenshot to attach here

[reyang]

It makes me feel that we're still trying to figure out what the output message is - this is wrong.
We need to check the return code, and forget about the output (if the output message is localized, do we end up parsing different languages? what if the wording changed?)

[helenlivsc]

Per a quick research, the output should include the call stack of the failure.

[reyang]

There is nothing wrong with arduino_debug.exe, it finished successfully, with a message in stderr complaining about the DPI.

The correct way of fixing this problem should be:

1. spawn the arduino_debug.exe by redirecting the stdout and stderr.
2. when the process finished, check the error code, if the exit code equals to zero, report success and done
3. if the error code is non-zero, report failure with whatever captured from stderr.

[helenlivsc]

I am sorry for the mind slip and thanks for your explanation. I tried to fix it through optimizing the related Promise.

[helenlivsc]

Tested the fix with a machine which presents the same issue and it works fine now. Shipped the fix to next installation package.