Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Move verbose console behind settings flag #31

Closed
joshbw opened this issue Jul 23, 2019 · 1 comment
Closed

Move verbose console behind settings flag #31

joshbw opened this issue Jul 23, 2019 · 1 comment
Assignees
Projects

Comments

@joshbw
Copy link
Contributor

joshbw commented Jul 23, 2019

The console.log right now is super verbose, which is helpful for debugging but not necessary for everyday users. The console.log should be behind a debug settings flag of some form, so it can be enabled selectively should a user want it

@joshbw joshbw self-assigned this Jul 23, 2019
@joshbw
Copy link
Contributor Author

joshbw commented Jul 30, 2019

I'll add to that while the code is littered with console.log, which lead me to think the output would be super verbose, the actual implementation is in connection.ts, and is nothing but a noop - SOOO both implement logging and hide it behind a settings flag (maybe unify the rule/engine dev flags, with rules validation also there)

@joshbw joshbw added this to To do in CLI Sep 10, 2019
@gfs gfs closed this as completed Feb 7, 2020
CLI automation moved this from To do to Done Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
CLI
  
Done
Development

No branches or pull requests

2 participants