Error when changing workspace config

[ferhtgoldaraz]

I've fot this output when changing some workspace settings.

TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
    at validateTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:101:25)
    at documents.onDidOpen (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:46:5)
    at CallbackList.invoke (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:114:39)
    at Emitter.fire (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:178:36)
    at connection.onDidOpenTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/lib/main.js:151:29)
    at handleNotification (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:460:43)
    at processMessageQueue (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:232:17)
    at Immediate.<anonymous> (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:219:13)
    at runCallback (timers.js:651:20)
    at tryOnImmediate (timers.js:624:5)
TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
    at validateTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:101:25)
    at documents.onDidChangeContent (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/server.js:43:5)
    at CallbackList.invoke (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:114:39)
    at Emitter.fire (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/events.js:178:36)
    at connection.onDidOpenTextDocument (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/lib/main.js:152:38)
    at handleNotification (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:460:43)
    at processMessageQueue (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:232:17)
    at Immediate.<anonymous> (/Users/fer/.vscode/extensions/MS-DevSkim.vscode-devskim-0.1.3/server/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/main.js:219:13)
    at runCallback (timers.js:651:20)
    at tryOnImmediate (timers.js:624:5)
[Error - 9:33:24 PM] Notification handler 'workspace/didChangeConfiguration' failed with message: Cannot read property 'Symbol(Symbol.iterator)' of undefined
[Error - 9:34:42 PM] Notification handler 'workspace/didChangeConfiguration' failed with message: Cannot read property 'Symbol(Symbol.iterator)' of undefined
[Error - 9:34:57 PM] Notification handler 'workspace/didChangeConfiguration' failed with message: Cannot read property 'Symbol(Symbol.iterator)' of undefined

[ferhtgoldaraz]

This is Mac OS Sierra, vscode 1.13.0

[joshbw]

Thanks @ferhtgoldaraz

I'll poke around and see if I can figure out what is up

[joshbw]

Hi @ferhtgoldaraz - I think I have the bug fixed. Would you be willing to do a quick test for me to make sure what I was seeing was also what you were. If you uninstall DevSkim, download the vsix install for the bugfix version, and then click on the "..." menu on the extension pane and click "install from VSIX" you should be able to get my bugfix version and check to see if the issue is replicated

[joshbw]

Replicated the error exactly as the static trace shows a couple different ways, and the fix seems to address all of the them (and is sort of obvious in retrospect). Went ahead and pushed a new version to the marketplace. Please let me know if you still see this error after updating. If not, I'll close out the issue. Thanks again - the feedback is super helpful

[ferhtgoldaraz]

Ok, I'll test it when I get home. Thx!

[joshbw]

I haven't heard more reports of issue so I believe this is taken care of