Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banned API with a space between API and () don't trigger rules #5

Closed
joshbw opened this issue Mar 10, 2017 · 1 comment
Closed

Banned API with a space between API and () don't trigger rules #5

joshbw opened this issue Mar 10, 2017 · 1 comment
Assignees
@joshbw
Labels
bug

Comments

@joshbw
Copy link
Contributor

joshbw commented Mar 10, 2017

Our regexes have a bug that don't take into account spaces:

gets(str);
gets (str);

The first gets will trigger a warning, but the second won't. We need to update a bunch of our rules to catch that
@joshbw joshbw added the bug label Mar 10, 2017
@joshbw joshbw self-assigned this Mar 10, 2017
@joshbw
Copy link
Contributor Author

joshbw commented Mar 13, 2017

Should be resolved by 8fdf0ad

@joshbw joshbw closed this as completed Mar 13, 2017
PavelBansky added a commit that referenced this issue Jun 27, 2017
@PavelBansky
Fix for issue #5 in VS plugin
2d91eff 
Null reference check in Language.GetLanguageFromFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshbw joshbw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshbw