Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance attribute matching rules to get better and fine grained query results #1114

Closed
janossch opened this issue Oct 13, 2021 · 3 comments
Closed
Assignees
Labels
Area-DicomQuery QIDO-RS Feature New feature request

Comments

@janossch
Copy link

User story
As a user of DICOMweb, I want to use better attribute matching rules during my queries so that I can get fine grained query results.

Acceptance criteria
Example for such a query match key with wildcard match (*,?):
(0008,1090) ManufacturerModelName = "Device*"

When I do the following example request (value has been url encoded):
https:\\<dicomweb-url>\series?ManufacturerModelName=Device%2A

then I get back results which contains the following values in ManufacturerModelName:
"Device A"
"Device B"

Rationale
DICOMweb standard states the following about attribute matching. source

"The matching semantics for each attribute are determined by the types of matching allowed by C-FIND."

The C-FIND attribute matching rules can be found here.

As a consequence the DICOMweb standard also allows to use these attribute matching rules and could be used to get better query results. These matching rules could at least be supported for default set of searchable attributes where the value representation allows it.

@smithago smithago added Area-DicomQuery QIDO-RS Feature New feature request labels Oct 20, 2021
@smithago
Copy link
Contributor

Thanks for the suggestions. We currently only support fuzzy matching on PN VR types.

@StevenBorg
Copy link
Contributor

@janossch, thanks for this submission! I'd love to dive a little deeper on the specific use cases you have. Effective searching is critical to streamline the workflow of a radiologist (or other user) -- we certainly get that. We're looking at a few other use cases which involve flexible search across a large number of DICOM metadata fields, and this certainly falls into that category. If you're willing to talk a bit more, ping me back here and we'll find a way to connect!

@esmadau
Copy link
Contributor

esmadau commented Jul 18, 2023

Closing this issue as stale given there hasn't been activity for a couple years. If anyone's willing to give more feedback and context, we can reopen this.

@esmadau esmadau closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DicomQuery QIDO-RS Feature New feature request
Projects
None yet
Development

No branches or pull requests

4 participants