Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIR-V] Run command in CodeGenSPIRV/intrinsics.sm6_6.ishelperlane.hlsl uses ps_6_0 instead of ps_6_6 #6708

Closed
chaoticbob opened this issue Jun 20, 2024 · 2 comments
Assignees
Labels
bug Bug, regression, crash spirv Work related to SPIR-V

Comments

@chaoticbob
Copy link

Don't this matters in practice, but the run command at the top of this file is using ps_6_0 instead of ps_6_6:
https://github.com/microsoft/DirectXShaderCompiler/blob/main/tools/clang/test/CodeGenSPIRV/intrinsics.sm6_6.ishelperlane.hlsl

// RUN: %dxc -T ps_6_0 -E main -fcgl  %s -spirv | FileCheck %s

Feature is SM 6.6 and file has sm6.6 in the name.

Just wanted to note this for the sake of consistency.

@chaoticbob chaoticbob added bug Bug, regression, crash needs-triage Awaiting triage spirv Work related to SPIR-V labels Jun 20, 2024
@s-perron s-perron self-assigned this Jun 20, 2024
@damyanp damyanp removed the needs-triage Awaiting triage label Jun 20, 2024
@llvm-beanz
Copy link
Collaborator

For DXIL we emulate IsHelperLane when targeting earlier shader models, so this feature is available in SM 6.0.

@chaoticbob
Copy link
Author

Ahh, my bad. i thought it was strictly SM 6.6 and the SPIR-V backend was making it available to SM 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash spirv Work related to SPIR-V
Projects
Archived in project
Development

No branches or pull requests

4 participants