Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust a jump target for efficient exception handling #7

Open
elfring opened this issue Aug 17, 2018 · 1 comment
Open

Adjust a jump target for efficient exception handling #7

elfring opened this issue Aug 17, 2018 · 1 comment

Comments

@elfring
Copy link

elfring commented Aug 17, 2018

A null pointer can be detected in the variable “outputBuffer” after a call of the function “ExAllocatePoolWithTag”.
I suggest to avoid the repetition of this condition check at the end of the function “AcpiTarget_EvaluateAcpiMethod” then by the addition of a jump label before the call of the function “FuncExit”.

@samtertzakian
Copy link
Member

Hi. Thank you for the feedback. ExAllocatePoolWithTag was removed entirely from DMF a few revisions ago. Can you please analyze again using the current version. Several changes were made to that section of the code when ExAllocatePoolWithTag was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants