-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated utils code #55
Comments
Michel you are absolutely right. There are nevertheless slight differences in the code logic for retrieve_workspace for instance. There was a similar discussion here. The problem is not so straightforward to solve but we are eager to get your inputs 😃 Do you have any suggestions ? |
I agree as well. The main reason that's preventing us from putting everything together is that only the |
Since this also seems to be duplicated among templates (and potentially among their implementations), I'd favor moving this upstream. Maybe we should then keep the discussion on the linked thread? Tentatively closing then. |
If there's a decision not to upstream it, we could explore removing the duplicate at least in this repo by:
|
The private package option would be a good alternative to reduce code duplication. Nevertherless, there is work in progress for the next release of the aml sdk (here an example regarding pipelines: azureml-previewss) which will probably require some adjustments to the solution. Hence, I would suggest keeping it simple and accessible (vs a package) even though it means having some duplicated code. |
Some of the
src/utils.py
code seems to be duplicated inside theoperations
folder:retrieve_workspace
get_dataset
This is a bit confusing when deploying the template.
The text was updated successfully, but these errors were encountered: