Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error propagation is not working properly even after upgrading to latest version of Sql server #209

Open
aaditya8 opened this issue Mar 26, 2024 · 1 comment
Labels
P1 Priority 1

Comments

@aaditya8
Copy link

We have updated SQLServer and Core libraries for Error propagation fix and started testing with both the modes "ErrorPropagationMode.SerializeExceptions", "ErrorPropagationMode.UseFailureDetails". Please find my observations help me with my use case.

Use Case :

We have one parent orchestration , one sub orchestration under parent orchestration , one task(Activity) under sub orchestration.
I am expecting to propagate the exception occurred in sub orchestration task to both Sub orchestration and Parent orchestration. Below are my findings.

TaskHubWorker:

   var taskHub = new TaskHubWorker(orchestrationService);
   taskHub.ErrorPropagationMode = ErrorPropagationMode.UseFailureDetails;
   orchestrationService.CreateIfNotExistsAsync().Wait();

Scenarios :

With SerializeExceptions : Inner Exception is always null in Sub Orchestration and Parent Orchestration.
With UseFailureDetails : I am able to see the Failure details(Including stack trace) of the Sub Orchestration Activity in Sub Orchestration. Same way i am able to see the failure details of Sub Orchestration in Parent Orchestration but not able to see the Failure details of Sub orchestration activity. Its coming as null.

Could you please help me with this.

@bachuv bachuv added P2 Priority 2 and removed Needs: Triage 🔍 labels Mar 26, 2024
@cgillum cgillum added P1 Priority 1 and removed P2 Priority 2 labels Mar 27, 2024
@cgillum
Copy link
Member

cgillum commented Mar 27, 2024

ErrorPropagationMode.SerializeExceptions is lower priority for us since it's considered the "old" way to propagating exception information and is already quite brittle. I can't guarantee much here.

ErrorPropagationMode.UseFailureDetails is expected to work, but it looks like we don't have an integration test to confirm whether it's working for sub-orchestration + activity scenarios. I'll look into adding one and fixing any issues it uncovers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1
Projects
None yet
Development

No branches or pull requests

3 participants