Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign-in: After successful sign-in user should be redirected to home screen #40

Closed
orezhko opened this issue Jul 31, 2017 · 1 comment
Closed

Sign-in: After successful sign-in user should be redirected to home screen #40

orezhko opened this issue Jul 31, 2017 · 1 comment
Assignees
@Vadim-Bulavin @IgorPopov-MS

Comments

@orezhko
Copy link
Contributor

orezhko commented Jul 31, 2017

No description provided.

@sharadagarwal
Copy link
Member

If the user clicks on sign-in through the hamburger and then does sign-in, then yes, they should go to the home screen.

However, if the user went to sign-in because they were previously not signed in and clicked on like, then after sign-in they should go back to the topic/comment/reply view that they were doing a like on and execute the like action.

Equivalent behavior if the user was trying to pin a topic, or add a new topic/comment/reply, or follow a user, or report a user/topic/comment/reply, or any other action that requires sign-in.

@IgorPopov-MS IgorPopov-MS self-assigned this Aug 4, 2017
IgorPopov-MS added a commit that referenced this issue Aug 7, 2017
@IgorPopov-MS
Fixed #40 + cleaned up menu/coordinator.
9e6653e
@IgorPopov-MS IgorPopov-MS mentioned this issue Aug 7, 2017
Merged
Vadim-Bulavin added a commit that referenced this issue Aug 9, 2017
@Vadim-Bulavin
#40 - Sign-in: After successful sign-in user should be redirected to …
7f11832 
…home screen - In progress
Vadim-Bulavin added a commit that referenced this issue Aug 10, 2017
@Vadim-Bulavin
#40 - Sign-in: After successful sign-in user should be redirected to …
2662aa1 
…home screen - Implemented
Vadim-Bulavin added a commit that referenced this issue Aug 10, 2017
@Vadim-Bulavin
#40 - Sign-in: After successful sign-in user should be redirected to …
cd09d45 
…home screen - Removed pods and updated folders
Vadim-Bulavin added a commit that referenced this issue Aug 10, 2017
@Vadim-Bulavin
Merge pull request #92 from Microsoft/vbulavin/issue_40
a93ea40 
Issue #40 implemented
@orezhko orezhko closed this as completed Aug 10, 2017
IgorPopov-MS added a commit that referenced this issue Aug 11, 2017
@IgorPopov-MS
Merge branch 'develop' into ipopov/topic-menu-feature
75ccb25 
* develop:
  My Profile Tests added
  Removed redundant [unowned self] and [weak self]
  1) Updated all services with new swagger API. 2) Added helper for UI testing. 3) Fixed failing tests. 4) Added tests for unauthorized error handler.
  Fixed post creation.
  #40 - Sign-in: After successful sign-in user should be redirected to home screen - Removed pods and updated folders
  #40 - Sign-in: After successful sign-in user should be redirected to home screen - Implemented
  #40 - Sign-in: After successful sign-in user should be redirected to home screen - In progress

# Conflicts:
#	EmbeddedSocial.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vadim-Bulavin Vadim-Bulavin

@IgorPopov-MS IgorPopov-MS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orezhko @sharadagarwal @Vadim-Bulavin @IgorPopov-MS