Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script fails if the zip package is not installed #3

Closed
gnolanccgs opened this issue Sep 17, 2021 · 4 comments
Closed

Script fails if the zip package is not installed #3

gnolanccgs opened this issue Sep 17, 2021 · 4 comments

Comments

@gnolanccgs
Copy link

Running this on a clean install of Raspberry Pi OS (Buster) fails near the end of the installation process because zip isn't installed by default and the error message for this is not repeated at the end of the installation process making it slightly confusing that the expected output image file is missing. If the script could include a contingency to install missing dependencies this would be helpful.

@damyka
Copy link
Contributor

damyka commented Sep 30, 2021

Thank you @gnolanccgs for pointing this out. I will make a note in the readme and will look into adding this to the bash script.

@gnolanccgs
Copy link
Author

gnolanccgs commented Oct 9, 2021

Thank you for this @damyka! Other than this minor issue I'm pleased to report that the script does a fantastic job.

@damyka
Copy link
Contributor

damyka commented Nov 19, 2021

@gnolanccgs, I have updated the readme and added a check/install for the missing dependency.

Thanks again for the feedback!

@gnolanccgs
Copy link
Author

@damyka, thank you very much for fixing this issue. I'm glad to be of some assistance. Closing this as there doesn't appear to be any further action required. All the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants