Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve FluentDesignSystemProvider interface #68

Closed
nicholasrice opened this issue Jul 23, 2021 · 2 comments
Closed

feat: improve FluentDesignSystemProvider interface #68

nicholasrice opened this issue Jul 23, 2021 · 2 comments
Assignees
@nicholasrice
Labels
closed:done Work is finished community:good-first-issue Good issues for first time contributors improvement A non-feature-adding improvement

Comments

@nicholasrice
Copy link
Contributor

馃檵 Feature Request

The FluentDesignSystemProvider should express the attributes available to the component (enumerated here) as component parameters.

Doing so makes the component more idiomatic and allows feature-discovery via intellisense for developers. As-is, developers must be aware of the HTML attributes used by the web-component to use the DesignSystemProvider features.

馃捇 Examples

<FluentDesignSystemProvider
    Density=1 
    ControlCornerRadius=4
>
    // ...
</FluentDesignSystemProvider>
@vertonghenb
Copy link

For a full list of attributes
https://www.fast.design/docs/api/fast-components.designsystemprovider
How are the Palette and Swatch datatypes implemented atm?

@EisenbergEffect EisenbergEffect added area:fast-blazor community:good-first-issue Good issues for first time contributors improvement A non-feature-adding improvement labels Aug 27, 2021
@EisenbergEffect
Copy link
Contributor

@nicholasrice This seems like a good one to try to pick up next week if possible.

@EisenbergEffect EisenbergEffect added the closed:done Work is finished label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicholasrice nicholasrice

Labels
closed:done Work is finished community:good-first-issue Good issues for first time contributors improvement A non-feature-adding improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EisenbergEffect @nicholasrice @vertonghenb