Add a new private package the cfp-template so it can run as a standalone project #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janechu
requested review from
nicholasrice and
EisenbergEffect
as code owners
3 tasks
EisenbergEffect
suggested changes
Sep 23, 2022
| import { welcome } from "./welcome/define.js"; | ||
|
|
||
| export default [ | ||
| welcome() |
There was a problem hiding this comment.
This doesn't seem correct. With the new compose API, this isn''t a function.
| import { template } from "./welcome.template.js"; | ||
| import { styles } from "./welcome.styles.js"; | ||
|
|
||
| export const definition = { |
There was a problem hiding this comment.
This all looks like out-of-date foundation code...
janechu
added a commit
that referenced
this pull request
Sep 23, 2022
…ault export (#123) # Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This change adds a utility file for use in the `@microsoft/cfp-template` which will take a dependency on the new private package introduced in #120 and use this utility to generate an exported script. This will eliminate pathing problems occurring from the current use of `fs` to read template files. Instead the contents of the files will be imported as they will be written to an exported script. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #121 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Merge #120 - Delete `template/` folder from `@microsoft/cfp-template` - Add `@microsoft/cfp-template-files` as a devDependency of `@microsoft/cfp-template` - Add a NodeJs script to execute the utility added in this PR against the contents of `@microsoft/cfp-template-files`
I'm in the middle of refactoring to solve a pathing issue, I can make that the next body of work. |
EisenbergEffect
approved these changes
Sep 23, 2022
janechu
deleted the
users/janechu/create-private-project-for-cfp-template
branch
3 tasks
janechu
added a commit
that referenced
this pull request
Sep 24, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This change updates the exports to use named exports from the `template` and `fs` utilities. This will simplify referencing them in the future. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #121 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - See notes on #120
3 tasks
janechu
added a commit
that referenced
this pull request
Sep 25, 2022
…emplate files into a ts file (#129) # Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This change removes the now redundant (with the addition of the private package in #120) and leverages the utility added in #123 & #128 to generate an export to be used by the `@microsoft/fast-cli`. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #121 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Re-evaluate all remaining pathing used by components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This change copies the files from the
@microsoft/cfp-templateinto a new private package@microsoft/cfp-template-files.This is the first step in de-coupling the logic for a standalone project and the template providing project.
🎫 Issues
Begins work on #121
👩💻 Reviewer Notes
These files are the same as the ones in the
./packages/cfp-template/template/folder.✅ Checklist
General
⏭ Next Steps
@microsoft/fast-cliexport for reading a project as a template and exporting initialization logic