Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up focus colors to existing controls #2438

Closed
bheston opened this issue Nov 15, 2019 · 5 comments
Closed

Hook up focus colors to existing controls #2438

bheston opened this issue Nov 15, 2019 · 5 comments
Projects

Comments

@bheston
Copy link
Collaborator

bheston commented Nov 15, 2019

What feature are you requesting?
We recently added focus to the color recipes. These values are not yet hooked up in controls.

What would be the benefit of adding this feature?
Adding to the design system to allow more flexibility in component interaction states.

@bheston bheston added the improvement A non-feature-adding improvement label Nov 15, 2019
@bheston bheston self-assigned this Nov 15, 2019
@bheston bheston added this to Backlog in Components via automation Nov 15, 2019
@chrisdholt
Copy link
Member

chrisdholt commented Nov 15, 2019

@bheston can you provide an example of how the recipe could be applied to something fairly simple? Just as an example. Without context here it would likely require a collaborator to do this, but if it's simple enough and we have the details it may be something a first time contributor could take on.

@bheston
Copy link
Collaborator Author

bheston commented Nov 15, 2019

A simple example is something like this search field
image

The rest, hover, active, and focus states may all be different.

The delta has already been added to the design system and color recipes, so the task here is to go into each style sheet and apply the focus color to the focus state. It's fairly mechanical and shouldn't require design. That being said, the current theory assumes that the focus color is in the same palette as the other state colors, which is true for the current way recipes are applied.

I'll tag it as a good first issue.

@bheston bheston added the community:good-first-issue Good issues for first time contributors label Nov 15, 2019
@bheston bheston removed their assignment Nov 18, 2019
@bheston
Copy link
Collaborator Author

bheston commented Nov 18, 2019

In the default design system configuration, the focus color should not be different than the resting state. For instance, tab-focusing a button should not change the color. This update will also validate the new color recipes in a real-world scenario. For instance, use a delta that's 10-20 larger than the hover or active state, which should result in a noticeable state change.
Note that foreground colors will need to be adjusted based on the focus background as well.

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the reason : stale label Jul 18, 2020
@EisenbergEffect EisenbergEffect added area:react and removed reason : stale community:good-first-issue Good issues for first time contributors improvement A non-feature-adding improvement labels Jul 20, 2020
@chrisdholt
Copy link
Member

closed with #3517

Components automation moved this from Backlog to Done Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Components
  
Done
Development

No branches or pull requests

3 participants