Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Strongly typed number field starts at min/max instead of 0 in Blazor #5315

Closed
vnbaaij opened this issue Oct 23, 2021 · 0 comments 路 Fixed by #5318
Closed

fix: Strongly typed number field starts at min/max instead of 0 in Blazor #5315

vnbaaij opened this issue Oct 23, 2021 · 0 comments 路 Fixed by #5318
Assignees
Labels
area:fast-components Pertains to the FAST design system bug A bug community:request Issues specifically reported by a member of the community. status:in-progress Work is in progress
Projects

Comments

@vnbaaij
Copy link
Contributor

vnbaaij commented Oct 23, 2021

馃悰 Bug Report

In the 2.0 WC release PR #5289 has been merged in. This has restored working of the up/down controls (:thumbsup: ) but it also introduced a new (and unwanted) effect in the Blazor <FluentNumberField> component.

Because we can strongly type components in Blazor, we need to supply Min and Max parameters to make sure the value stays within the designated type of the field. This now has the effect that when a field is empty, pressing Up(Down) shows the Min(Max) value instead of using 0 as a start point.

馃捇 Repro or Code Sample

Run the FluentServerSample from the fast-blazor repo and go to the Number test page.

馃 Expected Behavior

Empty number field should start from 0 when no initial value is supplied

馃槸 Current Behavior

image
This field holds a number of type integer (int). No initial value is set. Clicking 'Down' control shows maximum int value.. Should start at 0 and show -1

@vnbaaij vnbaaij added the status:triage New Issue - needs triage label Oct 23, 2021
@vnbaaij vnbaaij changed the title fix: [what is the issue?] in [where is the issue?] fix: Strongly typed number field starts at min/max instead of 0 in Blazor Oct 23, 2021
@robarbms robarbms self-assigned this Oct 24, 2021
@EisenbergEffect EisenbergEffect added area:fast-components Pertains to the FAST design system bug A bug community:request Issues specifically reported by a member of the community. status:in-progress Work is in progress and removed status:triage New Issue - needs triage labels Oct 25, 2021
@EisenbergEffect EisenbergEffect added this to Triage in Components via automation Oct 25, 2021
Components automation moved this from Triage to Done Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-components Pertains to the FAST design system bug A bug community:request Issues specifically reported by a member of the community. status:in-progress Work is in progress
Projects
Components
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants