Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmatched div tag in menu-item.template.ts #6840

Closed
oldoldman opened this issue Sep 23, 2023 · 7 comments
Closed

unmatched div tag in menu-item.template.ts #6840

oldoldman opened this issue Sep 23, 2023 · 7 comments
Assignees
Labels
area:fast-foundation Pertains to fast-foundation bug A bug closed:obsolete No longer valid community:good-first-issue Good issues for first time contributors

Comments

@oldoldman
Copy link

Hi guys,
I've double checked that </div> at this line has no matching start tag. Many thanks!!!

@oldoldman oldoldman added the status:triage New Issue - needs triage label Sep 23, 2023
@KingOfTac
Copy link
Collaborator

@chrisdholt @bheston could this be addressed as a part of the ongoing template updates or should we get a fix in sooner?

@KingOfTac KingOfTac added bug A bug community:good-first-issue Good issues for first time contributors area:fast-foundation Pertains to fast-foundation and removed status:triage New Issue - needs triage labels Sep 27, 2023
@kamalrohra
Copy link

Hello, I would like to work on this issue

@KingOfTac
Copy link
Collaborator

Hello, I would like to work on this issue

You're more than welcome to take this. I have gone ahead and assigned this to you.

@rahul0x00
Copy link

@KingOfTac Hi, it seems he's not working on this issue as he's taking so much time for a pretty easy fix. should i work on this?

@kamalrohra
Copy link

Hey I have made the required changes just creating a pr wasn't well for a couple of days sorry for the delay

@bheston
Copy link
Collaborator

bheston commented Oct 7, 2023

Agreed we should get this in aside from the larger template update. I've commented on the PR.

@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955. I see this was mentioned in a PR, we will be addressing open PRs and merging what we can before we snap an archive branch to preserve the latest state of Foundation, however to bring us up to date I am closing out issues.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation bug A bug closed:obsolete No longer valid community:good-first-issue Good issues for first time contributors
Projects
None yet
Development

No branches or pull requests

6 participants