Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code duplication between text-field and search components #6871

Closed
olaf-k opened this issue Nov 29, 2023 · 1 comment
Closed

fix: code duplication between text-field and search components #6871

olaf-k opened this issue Nov 29, 2023 · 1 comment
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage

Comments

@olaf-k
Copy link
Contributor

olaf-k commented Nov 29, 2023

馃悰 Bug Report

Not that much of a bug really but I noticed the search text input had a dedicated search component in fast-foundation, while other variants of the input (default text, tel, password and so on) were handled in text-field.
A large part of the functional code seem duplicated as a result.

馃 Expected Behavior

I would expect the text-field to provide a search variant so as to keep the code consistent in one place.
I understand this would be a breaking change (the search component would have to be deprecated) and I may have overlooked a significant difference that actually justifies having two separate entities, yell at me if that's the case 馃榿

@olaf-k olaf-k added the status:triage New Issue - needs triage label Nov 29, 2023
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage
Projects
None yet
Development

No branches or pull requests

2 participants