Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_name is actually more app_slug? #19

Closed
janpio opened this issue Nov 29, 2017 · 2 comments
Closed

app_name is actually more app_slug? #19

janpio opened this issue Nov 29, 2017 · 2 comments

Comments

@janpio
Copy link
Contributor

janpio commented Nov 29, 2017

Seems what I supply as app_name is actually used in the URL directly:

[21:03:08]: bad URI(is not URI?): /v0.1/apps/piotrowski/FastlaneExample (iOS)

(note the space in the app name)

On the other hand later in the process (if I replace the with - to make it work) the value seems to be used as a kind of "name":

[21:08:43]: App with name FastlaneExample-(iOS) not found, create one?
(y/n)
y

The app is actually created with this slug as name then as well, which makes for awkward names in the UI everywhere (as renaming in the web UI also seems to be broken).

@evkhramkov
Copy link
Contributor

Yes, you're right. We can consider adding app_display_name prompt to clarify that
cc @derpixeldan thoughts?

@dipree
Copy link
Member

dipree commented Apr 9, 2019

To unify the conversation handling in referenced ticket.

@dipree dipree closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants