Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get FHIR Server Version #1778

Closed
davidegiacometti opened this issue Mar 24, 2021 · 7 comments
Closed

Get FHIR Server Version #1778

davidegiacometti opened this issue Mar 24, 2021 · 7 comments
Labels
Tech-Debt VSTS-Current We are working on this item in the current sprint
Milestone

Comments

@davidegiacometti
Copy link

davidegiacometti commented Mar 24, 2021

User story
Add an API to retrieve FHIR server version corresponding to the GitHub release that is deployed.

@Ivanidzo4ka
Copy link
Contributor

https://www.hl7.org/fhir/capabilitystatement-definitions.html#CapabilityStatement.software
CapabilityStatement.software.version sounds like a good candidate to output that information.

We should probably put release information into that field.

@CaitlinV39 CaitlinV39 added the VSTS-Pending Prioritization We would like to add this to the backlog label Mar 25, 2021
@Ivanidzo4ka
Copy link
Contributor

We actually using that field and populate it with Assembly.Version value.
Which we populate with AssemblySemVer see https://gitversion.net/docs/reference/variables

problem its not descriptive enough.

Suitable for .NET AssemblyVersion. Defaults to Major.Minor.0.0 to allow the assembly to be hotfixed without breaking existing applications that may be referencing it.

@brendankowitz Can we switch to AssemblySemFileVer instead?

Our first minor upgrade happened 3 days ago, so all versions looks like 1.0.0.0

@brendankowitz
Copy link
Member

We set it here for the nuget packages and webdeploy files, but I don't think it gets set properly in the docker build.

command: build
arguments: '--configuration $(buildConfiguration) -p:ContinuousIntegrationBuild=true -p:AssemblyVersion="$(assemblySemVer)" -p:FileVersion="$(assemblySemFileVer)" -p:InformationalVersion="$(informationalVersion)" -p:Version="$(majorMinorPatch)" -warnaserror'

Our strategy is configured slightly differently atm in that we're only requiring recompilation on Major increments.

@Ivanidzo4ka
Copy link
Contributor

nuget packages
image

Can we switch that build command to use assemblySemFileVer instead of assemblySemVer or maybe change assignment of assemblySemVer to same assignment we have for assemblySemFileVer

@Ivanidzo4ka
Copy link
Contributor

Another option is not to use AssemblyVersion in capability statement, and use FileVersion instead.

@CaitlinV39 CaitlinV39 added Review Tag for PM/Dev Review and removed VSTS-Pending Prioritization We would like to add this to the backlog labels Aug 17, 2021
@CaitlinV39 CaitlinV39 added Tech-Debt VSTS-Pending Prioritization We would like to add this to the backlog and removed Review Tag for PM/Dev Review labels Aug 31, 2021
@CaitlinV39 CaitlinV39 added this to the backlog milestone Sep 16, 2021
@CaitlinV39 CaitlinV39 added VSTS-Current We are working on this item in the current sprint and removed VSTS-Pending Prioritization We would like to add this to the backlog labels Oct 22, 2021
@CaitlinV39 CaitlinV39 modified the milestones: backlog, S74 Oct 22, 2021
@CaitlinV39
Copy link
Contributor

CaitlinV39 commented Oct 22, 2021

AB#86147

@CaitlinV39
Copy link
Contributor

@davidegiacometti we added this in PR #2294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech-Debt VSTS-Current We are working on this item in the current sprint
Projects
None yet
Development

No branches or pull requests

4 participants